fix(media): re-enable React Compiler for the asset details form - #1841

Summary

Follow-up to #1840, rebased on main: removes the temporary 'use no memo' compiler opt-out from Details and fixes the Save-button bug at its actual root cause, so the plugin ships fully compiled again.

Root cause

DialogAssetEdit calls reset(generateDefaultValues(...)) in an effect when the dialog mounts and again whenever the asset is updated elsewhere (mutation listener). react-hook-form's reset() empties its internal field registry (_fields = {}) and relies on the render-time register() calls re-running on the next render to re-register every field. React Compiler memoizes the registered-field JSX in Details keyed on the stable register reference and asset-derived values, so register() never re-runs after a reset. From then on, typing in filename / title / alt text / description updates the DOM (the inputs are uncontrolled) but react-hook-form ignores the events — isDirty never flips and Save stays disabled. Tags kept working because they use Controller, which doesn't depend on render-time register() re-invocation.

Fix

• Pass {keepFieldsRef: true} to both reset() call sites (DialogAssetEdit, DialogTagEdit). This react-hook-form option keeps fields registered and applies the new values via setValue instead of wiping the registry.
• Remove 'use no memo' from Details — with the reset fixed, the compiler-memoized form works correctly.
• Convert the remaining inline const Footer = () => … components (and Header in DialogConfirm) to plain JSX, matching what fix(media): enable Save when editing asset string fields #1840 already did for DialogAssetEdit. An inline component gets a new function identity whenever captured values change, so React unmounted and remounted the whole footer subtree — including the Save button — on every form-state change. This also removes all the react/react-compiler lint suppressions that the pattern required.

Making the regression testable

Vitest previously ran against uncompiled source, so no test could catch compiler-specific regressions (the plugin ships compiled — reactCompiler: true in tsdown.config.ts). The plugin's Vitest config now applies the same @rolldown/plugin-babel + reactCompilerPreset combination that the build uses, so the whole suite — including the regression test added in #1840 — exercises compiler output.

Counterfactual check: removing 'use no memo' without keepFieldsRef fails 3 tests under the compiler ("enables Save after editing a string field (title)", "dispatches asset update when a field changes and the form is submitted", "persists a cleared Description as empty string so EXIF cannot refill it"); with keepFieldsRef all 205 pass. This also shows the useFormState / explicit onChange threading from #1840 were not the load-bearing parts of that workaround — only the compiler opt-out was.

Test plan

• pnpm --filter sanity-plugin-media exec vitest run — 205 tests pass, now exercising compiler output with no 'use no memo'
• Counterfactual: same suite fails 3 tests when keepFieldsRef is removed
• pnpm format, pnpm lint, pnpm knip, pnpm build, pnpm test run (1281 tests) all pass
• Manual verification in dev/test-studio (pnpm dev, compiler enabled via reactCompiler: {} in sanity.cli.ts), reproducing the reset-triggered failure mode in a real browser by patching the asset via the API while the dialog is open:
  • Without keepFieldsRef (compiler on, no 'use no memo'): after the externally-triggered form reset, typing in Title/Alt Text updates the inputs but Save stays disabled — bug reproduced.
  • With this branch: after the same external update and reset, typing re-enables Save and saving persists the edit.

Bug reproduction (broken build — Save stays disabled after the externally-triggered reset):

bug_repro_save_stays_disabled_without_fix.mp4

Fix demo (this branch — Save re-enables after the same reset and the edit saves):

fix_demo_save_enables_after_external_update.mp4

_{To show artifacts inline, enable in settings.}